fix(indexmap): harden sitemap pinging and indexnow key handling#7
Merged
Conversation
Tighten correctness, determinism, and operability across the sitemap pinging flow. IndexNow: - enforce 32-character lowercase hex keys for configured and discovered keys - reject key files whose contents do not exactly match the filename - stop accepting trailing newlines in key files - generate new keys in strict hex format - make existing key-file reuse deterministic by sorting candidates - include keyLocation in submission payloads when derivable - return structured ping results and print explicit rake task output Google: - require exact Search Console property matches instead of substring matching - memoize accessible site authorization checks to avoid repeated list_sites calls - return structured ping results and print explicit rake task output - downgrade unauthorized access logging to debug to keep test output clean Writer: - stop falling back to Time.now for sitemap index lastmod values - omit section lastmod when entries do not provide one, keeping output deterministic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten correctness, determinism, and operability across the sitemap pinging flow.
Changes
IndexNow:
Google:
Writer:
How to test
Release notes
Does this change need an explicit changelog or release-note callout beyond the PR title?
Checklist
About the maintainers
Built by Ethos Link, the team behind Reviato.
Capture. Interpret. Act.
Turn guest feedback into clear next steps for your team. Collect private appraisals, spot patterns across reviews, and act before small issues turn into public ones.