ENG-2810: Update IDP monitor result labels to Known/Unknown Systems#7586
Draft
dsill-ethyca wants to merge 2 commits intomainfrom
Draft
ENG-2810: Update IDP monitor result labels to Known/Unknown Systems#7586dsill-ethyca wants to merge 2 commits intomainfrom
dsill-ethyca wants to merge 2 commits intomainfrom
Conversation
Update action center display names for infrastructure monitor results from raw API keys to human-readable labels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2810
Description Of Changes
Update the action center monitor result description labels for infrastructure (IDP) monitors. The API returns
knownandunknownkeys in the updates object, which were previously displayed as raw keys. This adds proper display name mappings:known→ "Known System" / "Known Systems"unknown→ "Unknown System" / "Unknown Systems"Also updates the
InfrastructureMonitorUpdatestype to match the actual API response shape (known/unknowninstead ofokta_app).Code Changes
clients/admin-ui/src/features/data-discovery-and-detection/action-center/constants.ts- Add display name mappings and sort order entries forknown/unknownkeys; widenMONITOR_UPDATE_NAMEStype to includeInfrastructureMonitorUpdatesclients/admin-ui/src/types/api/models/InfrastructureMonitorUpdates.ts- Update type to reflect actual API response (known/unknowninstead ofokta_app)Steps to Confirm
/data-discovery/action-center)known/unknownkeysPre-Merge Checklist
CHANGELOG.mdupdated