Skip to content

ENG-2810: Update IDP monitor result labels to Known/Unknown Systems#7586

Draft
dsill-ethyca wants to merge 2 commits intomainfrom
ENG-2810-idp-monitor-copy
Draft

ENG-2810: Update IDP monitor result labels to Known/Unknown Systems#7586
dsill-ethyca wants to merge 2 commits intomainfrom
ENG-2810-idp-monitor-copy

Conversation

@dsill-ethyca
Copy link
Contributor

@dsill-ethyca dsill-ethyca commented Mar 6, 2026

Ticket ENG-2810

Description Of Changes

Update the action center monitor result description labels for infrastructure (IDP) monitors. The API returns known and unknown keys in the updates object, which were previously displayed as raw keys. This adds proper display name mappings:

  • known → "Known System" / "Known Systems"
  • unknown → "Unknown System" / "Unknown Systems"

Also updates the InfrastructureMonitorUpdates type to match the actual API response shape (known/unknown instead of okta_app).

Code Changes

  • clients/admin-ui/src/features/data-discovery-and-detection/action-center/constants.ts - Add display name mappings and sort order entries for known/unknown keys; widen MONITOR_UPDATE_NAMES type to include InfrastructureMonitorUpdates
  • clients/admin-ui/src/types/api/models/InfrastructureMonitorUpdates.ts - Update type to reflect actual API response (known/unknown instead of okta_app)

Steps to Confirm

  1. Navigate to the Action Center (/data-discovery/action-center)
  2. Observe infrastructure monitor results show "Known Systems" and "Unknown Systems" labels instead of raw known/unknown keys

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

Update action center display names for infrastructure monitor results
from raw API keys to human-readable labels.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Contributor

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Mar 6, 2026 4:17pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Mar 6, 2026 4:17pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fa333b79-1c12-4927-a7c4-8224932ac0d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ENG-2810-idp-monitor-copy

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant