Skip to content

ENG-2635: Standardize RDS & MySQL namespace meta field names#7589

Draft
JadeCara wants to merge 3 commits intomainfrom
ENG-2635-rds-namespace-field-migration
Draft

ENG-2635: Standardize RDS & MySQL namespace meta field names#7589
JadeCara wants to merge 3 commits intomainfrom
ENG-2635-rds-namespace-field-migration

Conversation

@JadeCara
Copy link
Contributor

@JadeCara JadeCara commented Mar 6, 2026

Ticket ENG-2635

Description Of Changes

Extend the existing alembic data migration (from PR #7500) to also rename namespace meta fields for rds_mysql and mysql connection types, and update the RDS MySQL connector to read the new field names.

PR #7500 renamed database_iddatabase_name and database_instance_iddatabase_instance_name on RDSPostgresNamespaceMeta but only migrated rds_postgres rows. This PR completes the migration for the remaining connection types:

  • rds_mysql: renames both database_iddatabase_name and database_instance_iddatabase_instance_name
  • mysql: renames database_iddatabase_name (no database_instance_id field)

Code Changes

  • src/fides/api/alembic/migrations/versions/xx_..._rename_rds_namespace_meta_fields.py - Add upgrade/downgrade statements for rds_mysql and mysql connection types
  • src/fides/api/service/connectors/rds_mysql_connector.py - Update namespace dict lookups from database_instance_id/database_id to database_instance_name/database_name

Steps to Confirm

  1. Run alembic upgrade head — migration should apply cleanly including new rds_mysql and mysql statements
  2. Run alembic downgrade <prev_rev> — downgrade should reverse all renames
  3. Verify RDS MySQL connector reads database_instance_name and database_name from namespace meta

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration label to the entry if your change includes a DB migration
    • Add a high-risk label to the entry if your change includes a high-risk change
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
  • Documentation:
    • No documentation updates required

🤖 Generated with Claude Code

Rename database_id → database_name and database_instance_id →
database_instance_name in the RDS MySQL connector and extend the
alembic data migration to cover rds_mysql and mysql connection types
in addition to rds_postgres.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Contributor

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Mar 6, 2026 9:02pm
fides-privacy-center Ignored Ignored Mar 6, 2026 9:02pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 202176aa-2ca6-44f2-90a2-a6a2b005c41a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ENG-2635-rds-namespace-field-migration

Comment @coderabbitai help to get the list of available commands and usage tips.

Jade Wibbels and others added 2 commits March 6, 2026 14:01
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant