ENG-2635: Standardize RDS & MySQL namespace meta field names#7589
Draft
ENG-2635: Standardize RDS & MySQL namespace meta field names#7589
Conversation
Rename database_id → database_name and database_instance_id → database_instance_name in the RDS MySQL connector and extend the alembic data migration to cover rds_mysql and mysql connection types in addition to rds_postgres. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2635
Description Of Changes
Extend the existing alembic data migration (from PR #7500) to also rename namespace meta fields for
rds_mysqlandmysqlconnection types, and update the RDS MySQL connector to read the new field names.PR #7500 renamed
database_id→database_nameanddatabase_instance_id→database_instance_nameonRDSPostgresNamespaceMetabut only migratedrds_postgresrows. This PR completes the migration for the remaining connection types:rds_mysql: renames bothdatabase_id→database_nameanddatabase_instance_id→database_instance_namemysql: renamesdatabase_id→database_name(nodatabase_instance_idfield)Code Changes
src/fides/api/alembic/migrations/versions/xx_..._rename_rds_namespace_meta_fields.py- Add upgrade/downgrade statements forrds_mysqlandmysqlconnection typessrc/fides/api/service/connectors/rds_mysql_connector.py- Update namespace dict lookups fromdatabase_instance_id/database_idtodatabase_instance_name/database_nameSteps to Confirm
alembic upgrade head— migration should apply cleanly including new rds_mysql and mysql statementsalembic downgrade <prev_rev>— downgrade should reverse all renamesdatabase_instance_nameanddatabase_namefrom namespace metaPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works🤖 Generated with Claude Code