Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses database cold start issues by modifying the container app configuration to maintain at least one running replica instead of scaling to zero.
- Changed minimum replicas from 0 to 1 to prevent cold starts
- Updated comment to reflect the new scaling strategy
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| # Minimum scaling for cost optimization | ||
| min_replicas = 0 # Scale to zero when no traffic (cheapest option) | ||
| min_replicas = 1 # Reduce cold start |
There was a problem hiding this comment.
[nitpick] The comment should be more descriptive about the trade-off being made. Consider: '# Keep 1 replica running to avoid cold starts (increases cost but improves response time)'
Suggested change
| min_replicas = 1 # Reduce cold start | |
| min_replicas = 1 # Keep 1 replica running to avoid cold starts (increases cost but improves response time) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.