Decode prompt token trace payloads#455
Open
SunnySoldier357 wants to merge 1 commit into
Open
Conversation
Hydrate prompt_token_ids from Fireworks tracing payloads so RemoteRolloutProcessor can pass token-native prompt IDs through assistant turn metadata. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execution_metadata.extra.prompt_token_idsandprompt_token_ids_metadatafrompayloads.prompt_token_ids.RemoteRolloutProcessormulti-turnassistant_turn_payloads.RemoteRolloutProcessoragainst a Fireworks tracing gateway deployment.Test plan
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 conda run -n eval python -m pytest -p pytest_asyncio.plugin tests/adapters/test_fireworks_tracing_logprobs.py tests/adapters/test_fireworks_tracing_prompt_token_ids.py tests/pytest/test_tracing_utils.pyconda run -n eval python scripts/test_remote_rollout_prompt_token_ids.py --timeout-seconds 90 --poll-interval 2E2E used dev tracing gateway/consumer from FIR2-1747 and
accounts/pyroworks-dev/deployments/malaysia2-intended-butterfly; it verifiedassistant_turn_payloads[0].prompt_token_idswas hydrated with 13 prompt IDs.Made with Cursor