Open
Conversation
This patch introduces the log_exception function for potential reuse of the logic that was formerly in log_traceback. In subsequent commits the log_exception function will be used to replace ad hoc error messages. This in particular improves the rendering of AGS errors, which as of version 0.3.2 uses exception notes to provide error context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
log_exceptionfunction for potential reuse of the logic that was formerly inlog_traceback.The log_exception function is then used to replace ad hoc error messages. This in particular improves the rendering of AGS errors, which as of version 0.3.2 uses exception notes to provide error context.