This repository was archived by the owner on Mar 31, 2021. It is now read-only.
SEO and W3C update#49
Open
m1ga wants to merge 4 commits into
Open
Conversation
Fohlen
reviewed
Oct 20, 2019
Fohlen
left a comment
Fohlen
left a comment
Contributor
There was a problem hiding this comment.
Overall your changes make quite a lot of sense! Thanks a lot!
| background-color: transparent !important; | ||
| } | ||
|
|
||
| h1 { |
Contributor
There was a problem hiding this comment.
I am not sure if we should fiddle with the size(s) of the headers. Is this explicitly mentioned in the SEO report (as being to small)? I think the bootstrap default is good because it also respects responsiveness and it is more subtle (easier to read)
Contributor
Author
There was a problem hiding this comment.
h1 wasn't used. So I've made it to look like the headline before (that wasn't a h1). So if I remove that it will be bigger than before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some issues doing a W3C check and SEO check (https://www.seobility.net/en/seocheck/):
TODO after the PR: