fix(tool): sanitize ScriptedTool callback errors by default#1228
Closed
fix(tool): sanitize ScriptedTool callback errors by default#1228
Conversation
chaliy
force-pushed
the
fix/issue-1172-scripted-tool-error-sanitization
branch
from
58e4cba to
c6f65e1
Compare
Closes #1172 — Callback error messages are now replaced with a generic "callback failed (error code 1)" in tool output when sanitize_errors is enabled (default: true). Full errors logged to debug output. Prevents internal state leakage (connection strings, paths, stack traces) through tool output to LLM agents.
chaliy
force-pushed
the
fix/issue-1172-scripted-tool-error-sanitization
branch
from
b985b2a to
14197c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1172
Changes already merged to main via other PRs in this batch. Closing as incorporated.
sanitize_errorsdefaults totrueonScriptedToolBuilderErr(msg)replaced with generic"callback failed"in tool outputScriptedToolBuilder::sanitize_errors(false)to opt out