Add sound notification filters by item type#32
Open
ajpemok wants to merge 2 commits intoexApiTools:masterfrom
Open
Add sound notification filters by item type#32ajpemok wants to merge 2 commits intoexApiTools:masterfrom
ajpemok wants to merge 2 commits intoexApiTools:masterfrom
Conversation
- add sound alert toggles for uniques, currency, fragments, maps, cards, essences, gems and jewels, beasts, and other types - route ground drop sound alerts through shared category and playback helpers - keep existing value threshold and custom unique sound behaviour while allowing item-type filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
This change separates sound notifications by item category so drop alerts can be limited to specific kinds of items.
The existing ground-drop sound logic now uses shared helpers for: