SED-4625 Table services are not secured

[david-stephan]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the server-side plugin architecture by centralizing all plugin lifecycle management into a single ServerPlugin interface through the use of default methods. This change streamlines the plugin initialization process within ControllerServer by introducing a more robust two-phase loading mechanism, which allows for dynamic registration of a ModuleChecker. The overall impact is a more cohesive, flexible, and easier-to-maintain plugin system.

Highlights

• Unified Plugin Lifecycle: The ControllerInitializationPlugin interface was removed, and its lifecycle methods (e.g., checkPreconditions, init, recover, finalizeStart, preShutdownHook, postShutdownHook) were integrated into the ServerPlugin interface as default methods. This consolidates server-side plugin lifecycle management into a single, more flexible interface.
• Simplified OptionalPlugin Validation: The validate() method in OptionalPlugin now includes a default implementation that always returns true, eliminating the need for AbstractPlugin to explicitly override it.
• Enhanced Plugin Loading Mechanism: The ServerPluginManager was refactored to support a two-phase plugin loading process. It now initially scans for plugins without a ModuleChecker to allow plugins to register one, and then rebuilds the manager with the registered ModuleChecker to filter plugins, improving flexibility in plugin initialization.
• Streamlined VersionManagerPlugin: The VersionManagerPlugin was simplified by removing several empty lifecycle methods and consolidating its core logic into the init method, aligning with the new ServerPlugin default method approach.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant and well-executed refactoring of the server plugin framework. The core change is the consolidation of plugin lifecycle hooks into a single ServerPlugin interface that uses default methods, which greatly simplifies plugin implementations by removing the need for boilerplate empty methods. The ControllerInitializationPlugin has been removed, and its responsibilities are now part of the unified ServerPlugin interface.

A key improvement is the introduction of a two-phase plugin initialization process in ControllerServer. This allows plugins to register infrastructure components, such as a ModuleChecker, during an initial checkPreconditions phase. This component can then be used to filter the set of active plugins for subsequent initialization phases, all without requiring multiple costly classpath scans. This is achieved through a new rebuild mechanism in ServerPluginManager.

The ServerPluginManager itself has been refactored to be non-generic and more efficient by caching the list of all discovered plugins. The use of generics has been improved throughout the changed files, for example by parameterizing previously raw types and fixing incorrect builder usage.

Overall, these changes enhance the modularity, clarity, and performance of the plugin system. The pull request title, "SED-4625 Table services are not secured", does not seem to relate to the content of the code changes, which focus on this framework refactoring.