SED-4543 Drilldown workflow in execution tree

[dvladir]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the execution tree drilldown experience by removing redundant dedicated tabs and navigation buttons. The changes aim to simplify the user interface and consolidate tree navigation, likely integrating drilldown functionality more seamlessly into existing views. Additionally, the code was refactored to improve maintainability by marking several properties as immutable.

Highlights

• Simplified Execution Tree Navigation: Removed dedicated 'Execution Tree' and 'Partial Tree' tabs, along with all associated UI buttons and logic for 'Open tree view' or 'Reveal in execution tree' from various components, streamlining the drilldown workflow.
• Code Refactoring for Immutability: Refactored several component properties to be 'readonly' in TypeScript, enhancing code maintainability and predictability by preventing accidental reassignments after initialization.
• Removed Redundant Components and Services: Eliminated several files, components, and service dependencies related to the previously separate 'Execution Tree' and 'Partial Tree' tabs, reducing codebase complexity.

Changelog

• projects/step-frontend/src/lib/modules/execution/components/aggregated-tree-node-dialog/aggregated-tree-node-dialog.component.html
  • Removed event emitters for opening tree view from report node details and iteration list components.
• projects/step-frontend/src/lib/modules/execution/components/aggregated-tree-node-dialog/aggregated-tree-node-dialog.component.ts
  • Removed the handleOpenTreeView method.
  • Applied minor formatting changes to import statements and tap operator.
• projects/step-frontend/src/lib/modules/execution/components/aggregated-tree-node-iteration-list/aggregated-tree-node-iteration-list.component.html
  • Removed the 'actions' column, which contained the 'Open tree for this iteration' button.
• projects/step-frontend/src/lib/modules/execution/components/aggregated-tree-node-iteration-list/aggregated-tree-node-iteration-list.component.scss
  • Adjusted the padding-top for table cells to 0.
• projects/step-frontend/src/lib/modules/execution/components/aggregated-tree-node-iteration-list/aggregated-tree-node-iteration-list.component.ts
  • Removed the openTreeView output property.
  • Added readonly modifier to tableSearch, matSort, sort, artefactHash, searchCtrlValue, and statusCtrlValue properties.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-progress/alt-execution-progress.component.ts
  • Removed the import and injection of AGGREGATED_TREE_TAB_STATE.
  • Removed all related logic for initializing and managing the _aggregatedTreeTabState.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-report/alt-execution-report.component.html
  • Removed event emitters for opening tree view from test cases and keywords components.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-tabs/alt-execution-tabs.component.html
  • Updated the tab rendering condition to exclude the 'Tree' tab.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-tree-partial-tab/alt-execution-tree-partial-tab.component.html
  • Removed file.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-tree-partial-tab/alt-execution-tree-partial-tab.component.scss
  • Removed file.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-tree-partial-tab/alt-execution-tree-partial-tab.component.ts
  • Removed file.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-tree-tab/alt-execution-tree-tab.component.html
  • Removed file.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-tree-tab/alt-execution-tree-tab.component.scss
  • Removed file.
• projects/step-frontend/src/lib/modules/execution/components/alt-execution-tree-tab/alt-execution-tree-tab.component.ts
  • Removed file.
• projects/step-frontend/src/lib/modules/execution/components/alt-keyword-inline-drilldown/alt-report-node-details.component.html
  • Removed the button for opening a partial tree view as a tab.
• projects/step-frontend/src/lib/modules/execution/components/alt-keyword-inline-drilldown/alt-report-node-details.component.ts
  • Removed the openTreeView output property.
  • Added readonly modifier to partialTree and aggregatedNode properties.
  • Updated the searchFor method's return type to void.
• projects/step-frontend/src/lib/modules/execution/components/alt-report-node-keywords/alt-report-node-keywords.component.html
  • Removed the 'actions' column, which contained the 'Show this node in tree view' button.
• projects/step-frontend/src/lib/modules/execution/components/alt-report-node-keywords/alt-report-node-keywords.component.ts
  • Removed the openKeywordInTreeView output property.
  • Added readonly modifier to tableSearch and keywordColumnIds properties.
• projects/step-frontend/src/lib/modules/execution/components/alt-report-nodes-testcases/alt-report-nodes-testcases.component.html
  • Removed the 'actions' column, which contained the 'Reveal this test case in execution tree' button.
• projects/step-frontend/src/lib/modules/execution/components/alt-report-nodes-testcases/alt-report-nodes-testcases.component.ts
  • Removed the openTestCaseInTreeView output property.
  • Added readonly modifier to the tableSearch property.
• projects/step-frontend/src/lib/modules/execution/execution.module.ts
  • Removed imports, declarations, and exports for AltExecutionTreeTabComponent and AltExecutionTreePartialTabComponent.
  • Removed AGGREGATED_TREE_TAB_STATE from providers and cleanup logic.
  • Removed routing paths for '/tree' and '/sub-tree/:reportNodeId'.
• projects/step-frontend/src/lib/modules/execution/services/alt-execution-tabs.service.ts
  • Removed STATIC_TABS.TREE from the enum and tab initialization logic.

Activity

• The pull request was created by dvladir.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the execution view by removing the drilldown workflow that opened a partial execution tree in a separate tab. This change simplifies the user interface and the codebase significantly by removing several components, services, and routes associated with the old workflow. The deletions are consistent across the project. Additionally, the opportunity was taken to improve code quality by marking several class properties as readonly, which is a good practice. The changes are clean and well-executed, and I have no further recommendations.

[neogucky]

Approved removal of tree tab - later we will have to do a new review of follow-up tasks related to drilldown