[fix] Prevent balance from being fetched twice on startup#190
Open
steveluscher wants to merge 1 commit into
Open
[fix] Prevent balance from being fetched twice on startup#190steveluscher wants to merge 1 commit into
steveluscher wants to merge 1 commit into
Conversation
Author
|
There's a related PR in the wallet adapter repo that should help reduce re-renders of this application even more: anza-xyz/wallet-adapter#193 |
Contributor
|
That PR has been merged and released :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now, we fetch the wallet balance twice on startup.
This is because of the way we've configured the effect that fetches the wallet balance on startup. It re-runs whenever anything in
walletchanges, even though we only need thepublicKeyto be able to fetch the balance.In this pull request, we modify the dependencies array so that the only thing that can cause this effect to re-run, is a change in the
publicKey.Type of change
How Has This Been Tested?
Loaded the mint site locally, and noticed that now we only call the
getBalanceAPI once.