Skip to content

Fix(util): ensure seed is < 2**23 for np.random.seed() #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickCrews wants to merge 2 commits into
base: v8.3.x
Choose a base branch
from
+8 −2
Open

Fix(util): ensure seed is < 2**23 for np.random.seed() #965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2135938
Fix(util): ensure seed is < 2**23 for np.random.seed()
NickCrews Jan 15, 2026
30c9360
fix: limit range of seed passed to torch.manual_seed()
NickCrews Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions thinc/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,18 @@ def gpu_is_available():
def fix_random_seed(seed: int = 0) -> None: # pragma: no cover
"""Set the random seed across random, numpy.random and cupy.random."""
random.seed(seed)
numpy.random.seed(seed)
numpy.random.seed(seed % 2**32)
if has_torch:
torch.manual_seed(seed)
# Must be within the inclusive range [-0x8000_0000_0000_0000, 0xffff_ffff_ffff_ffff]
# https://github.com/pytorch/pytorch/blob/d38164a545b4a4e4e0cf73ce67173f70574890b6/torch/random.py#L32-L41
torch.manual_seed(seed % 0xffff_ffff_ffff_ffff)
if has_cupy_gpu:
# cupy has no documented range limit on seed as of 2026-01-15
# https://docs.cupy.dev/en/latest/reference/generated/cupy.random.seed.html
cupy.random.seed(seed)
if has_torch and has_torch_cuda_gpu:
# torch.cuda has no documented range limit on seed as of 2026-01-15
# https://docs.pytorch.org/docs/stable/generated/torch.cuda.manual_seed_all.html
torch.cuda.manual_seed_all(seed)
torch.backends.cudnn.deterministic = True
torch.backends.cudnn.benchmark = False
Expand Down
Loading