feat(react-native-google-cast): add startDiscoveryAfterFirstTapOnCastButton and physicalVolumeButtonsWillControlDeviceVolume options to iOS #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Button and physicalVolumeButtonsWillControlDeviceVolume options to IOS
… we can publish to npm and clone from app
julianD77
changed the title
…ase 4.8.2 of the iOS google-cast-sdk you no longer specify to use the no-bluetooth variant of the SDK so all permissions seem to be required Set version to 8.0.3
…e not required if we are correctly linking agains the latest iOS google-cast-sdk 4.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To support configuring the iOS
startDiscoveryAfterFirstTapOnCastButtonandphysicalVolumeButtonsWillControlDeviceVolumeoptions.There are known issues regarding Cast device discovery with recent
google-cast-sdkversions (v4.8.0/1) andreact-native-google-castlibraries. The advice to mitigate these issues is to setstartDiscoveryAfterFirstTapOnCastButtonto false and allow device discovery to take place when the App launches. More information hereHow
The two options have been added to the plugin configuration options.
Test Plan
Tested on multiple devices locally.