chore: pin GitHub Actions to commit SHAs [PinnR]#44
Merged
Conversation
jmpage
previously approved these changes
Apr 16, 2026
Contributor
|
The test failure here is a real regression caused by pg 1.6.3 (released Dec 29, 2025), not a pre-existing issue. The activerecord_6.1 appraisal has no Gemfile.lock, so bundler always resolves to the latest pg — which is now 1.6.3. The last passing CI run (Dec 8, 2025) used pg 1.6.2. The failing test is the notify_only listener spec in listener_spec.rb — it expects nil payload, which relies on Ruby's missing-argument behavior when the callback is invoked with no args. pg 1.6.3 appears to change notification payload handling in a way that breaks this. Fix: pin pg in gemfiles/activerecord_6.1.gemfile: gem "pg", "< 1.6.3" |
pg 1.6.3 introduced a regression that breaks the notify_only listener spec. The activerecord_6.1 gemfile has no Gemfile.lock so bundler always resolves to the latest pg, which is now 1.6.3. Pinning to < 1.6.3 resolves to 1.6.2, which passes all 6 listener specs.
thiagopecanha
approved these changes
Apr 24, 2026
bray
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MX-1360
PinnR: GitHub Actions Security Update
This PR pins GitHub Actions to specific commit SHAs to improve supply chain security.
Why?
Floating tags like
v3or branches likemaincan be moved to point to different commits, potentially introducing malicious code. Pinning to SHAs ensures the exact code version is used.Changes
ci.ymlactions/checkoutv4→de0fac2e4500dabe0009e67214ff5f5447ce83dd(v6.0.2)ci.ymlruby/setup-rubyv1→7372622e62b60b3cb750dcd2b9e32c247ffec26a(v1.302.0)ci.ymlactions/checkoutv4→de0fac2e4500dabe0009e67214ff5f5447ce83dd(v6.0.2)ci.ymlruby/setup-rubyv1→7372622e62b60b3cb750dcd2b9e32c247ffec26a(v1.302.0)codeql.ymlactions/checkoutv3→de0fac2e4500dabe0009e67214ff5f5447ce83dd(v6.0.2)codeql.ymlgithub/codeql-action/initv2→65216971a11ded447a6b76263d5a144519e5eee1(codeql-bundle-v2.25.2)codeql.ymlgithub/codeql-action/autobuildv2→65216971a11ded447a6b76263d5a144519e5eee1(codeql-bundle-v2.25.2)codeql.ymlgithub/codeql-action/analyzev2→65216971a11ded447a6b76263d5a144519e5eee1(codeql-bundle-v2.25.2)dependency-review.ymlactions/checkoutv3→de0fac2e4500dabe0009e67214ff5f5447ce83dd(v6.0.2)dependency-review.ymlactions/dependency-review-actionv3→2031cfc080254a8a887f58cffee85186f0e49e48(v4.9.0)release.ymlruby/setup-rubyv1→7372622e62b60b3cb750dcd2b9e32c247ffec26a(v1.302.0)Note
If this PR is closed without merging, the branch
pinnR/GHA-Update-2026-04-15will need to be deleted manually.🤖 Generated by PinnR