Conversation
Member
|
I'm holding off on this because I think a better design has the thresholding unit parameterized to output a sparse array or MLX array, then the rates unit will auto-detect which code path to take based on the input namespace. I like this design better because it is a smaller increase in the decision space for the user (simply one more toggle, not an A+B vs C), and it is a pure upgrade for the rate unit which could benefit other scenarios. I'll leave this PR in place until that new design is done but ultimately I will not be merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New combo threshold and rate node that makes use of mlx