-
Notifications
You must be signed in to change notification settings - Fork 357
Allow ParameterConstraint for numerical, ordered ChoiceParameter #4823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sunnyshen321
wants to merge
1
commit into
facebook:main
Choose a base branch
from
sunnyshen321:export-D91528315
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+370
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91528315. |
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Jan 27, 2026
…ebook#4823) Summary: Allow ParameterConstraint for numerical, ordered ChoiceParameter Differential Revision: D91528315
9396055 to
edead93
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4823 +/- ##
=======================================
Coverage 96.76% 96.77%
=======================================
Files 593 593
Lines 62037 62134 +97
=======================================
+ Hits 60031 60130 +99
+ Misses 2006 2004 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edead93 to
edb8323
Compare
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 4, 2026
…ebook#4823) Summary: Allow ParameterConstraint for numerical, ordered ChoiceParameter Differential Revision: D91528315
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 4, 2026
…ebook#4823) Summary: Allow ParameterConstraint for numerical, ordered ChoiceParameter Differential Revision: D91528315
edb8323 to
9aecee6
Compare
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 10, 2026
…ebook#4823) Summary: Allow ParameterConstraint for numerical, ordered ChoiceParameter Reviewed By: saitcakmak Differential Revision: D91528315
b7d8017 to
dd417b2
Compare
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 11, 2026
…ebook#4823) Summary: Allow ParameterConstraint for numerical, ordered ChoiceParameter --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=23a1fcba-077a-11f1-a38b-c323d4dea8dd&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=23a1fcba-077a-11f1-a38b-c323d4dea8dd&tab=Trace) Reviewed By: saitcakmak Differential Revision: D91528315
…ebook#4823) Summary: Allow ParameterConstraint for numerical, ordered ChoiceParameter --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=23a1fcba-077a-11f1-a38b-c323d4dea8dd&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=23a1fcba-077a-11f1-a38b-c323d4dea8dd&tab=Trace) Reviewed By: saitcakmak Differential Revision: D91528315
dd417b2 to
3b4c37d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allow ParameterConstraint for numerical, ordered ChoiceParameter
Differential Revision: D91528315