-
Notifications
You must be signed in to change notification settings - Fork 357
Upstream MultiTypeExperiment features into Experiment #4873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3121370 to
73b1886
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4873 +/- ##
==========================================
- Coverage 96.76% 96.73% -0.03%
==========================================
Files 591 591
Lines 61879 61949 +70
==========================================
+ Hits 59875 59927 +52
- Misses 2004 2022 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4873 +/- ##
==========================================
- Coverage 96.76% 96.73% -0.03%
==========================================
Files 591 591
Lines 61955 62025 +70
==========================================
+ Hits 59948 60001 +53
- Misses 2007 2024 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
73b1886 to
8dde1b5
Compare
8dde1b5 to
e1139f4
Compare
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91618283. |
Summary: These changes will enable us to deprecate multitypeexperment, simplifying the Ax data model ahead of storage changes. 1. In Experiment make the default_trial_type a new Key.DEFAULT_TRIAL_TYPE value instead of None 2. Move over logic for bookkeeping metric -> trial_type and runner -> trial_type mappings 3. Treat LONG_ and SHORT_RUN trial types as special cases which map to DEFAULT_TRIAL_TYPE (i.e. if a Trial has trial_type=LONG_RUN then use whichever metrics and runners are mapped to DEFAULT_TRIAL_TYPE 4. Fix tests which expect the default_trial_type of an Experiment to be None This diff allows us to remove all isinstance(foo, MultiTypeExperiment) checks in Ax in the next diff, then to deprecate MultiTypeExperiment entirely. Differential Revision: D91618283
Summary: These changes will enable us to deprecate multitypeexperment, simplifying the Ax data model ahead of storage changes. 1. In Experiment make the default_trial_type a new Key.DEFAULT_TRIAL_TYPE value instead of None 2. Move over logic for bookkeeping metric -> trial_type and runner -> trial_type mappings 3. Treat LONG_ and SHORT_RUN trial types as special cases which map to DEFAULT_TRIAL_TYPE (i.e. if a Trial has trial_type=LONG_RUN then use whichever metrics and runners are mapped to DEFAULT_TRIAL_TYPE 4. Fix tests which expect the default_trial_type of an Experiment to be None This diff allows us to remove all isinstance(foo, MultiTypeExperiment) checks in Ax in the next diff, then to deprecate MultiTypeExperiment entirely. Differential Revision: D91618283
Summary: These changes will enable us to deprecate multitypeexperment, simplifying the Ax data model ahead of storage changes. 1. In Experiment make the default_trial_type a new Key.DEFAULT_TRIAL_TYPE value instead of None 2. Move over logic for bookkeeping metric -> trial_type and runner -> trial_type mappings 3. Treat LONG_ and SHORT_RUN trial types as special cases which map to DEFAULT_TRIAL_TYPE (i.e. if a Trial has trial_type=LONG_RUN then use whichever metrics and runners are mapped to DEFAULT_TRIAL_TYPE 4. Fix tests which expect the default_trial_type of an Experiment to be None This diff allows us to remove all isinstance(foo, MultiTypeExperiment) checks in Ax in the next diff, then to deprecate MultiTypeExperiment entirely. Differential Revision: D91618283
e1139f4 to
db3a3f2
Compare
Summary:
These changes will enable us to deprecate multitypeexperment, simplifying the Ax data model ahead of storage changes.
This diff allows us to remove all isinstance(foo, MultiTypeExperiment) checks in Ax in the next diff, then to deprecate MultiTypeExperiment entirely.
Differential Revision: D91618283