Remove bifrucation around MultiTypeExperiment#4874
Open
mpolson64 wants to merge 2 commits intofacebook:mainfrom
Open
Remove bifrucation around MultiTypeExperiment#4874mpolson64 wants to merge 2 commits intofacebook:mainfrom
mpolson64 wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mpolson64
force-pushed
the
export-D91920991
branch
2 times, most recently
from
3056786 to
490b4d8
Compare
mpolson64
force-pushed
the
export-D91920991
branch
from
490b4d8 to
f5e7961
Compare
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91920991. |
Summary: These changes will enable us to deprecate multitypeexperment, simplifying the Ax data model ahead of storage changes. 1. In Experiment make the default_trial_type a new Key.DEFAULT_TRIAL_TYPE value instead of None 2. Move over logic for bookkeeping metric -> trial_type and runner -> trial_type mappings 3. Treat LONG_ and SHORT_RUN trial types as special cases which map to DEFAULT_TRIAL_TYPE (i.e. if a Trial has trial_type=LONG_RUN then use whichever metrics and runners are mapped to DEFAULT_TRIAL_TYPE 4. Fix tests which expect the default_trial_type of an Experiment to be None This diff allows us to remove all isinstance(foo, MultiTypeExperiment) checks in Ax in the next diff, then to deprecate MultiTypeExperiment entirely. Differential Revision: D91618283
Summary: With recent changes to experiment we no longer need this bifructation. Next diff will remove places where we construct MultiTypeExperiment, and the one after will deprecate the class entirely Differential Revision: D91920991
mpolson64
force-pushed
the
export-D91920991
branch
from
f5e7961 to
a172262
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Feb 10, 2026
Summary: With recent changes to experiment we no longer need this bifructation. Next diff will remove places where we construct MultiTypeExperiment, and the one after will deprecate the class entirely Differential Revision: D91920991
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With recent changes to experiment we no longer need this bifructation.
Next diff will remove places where we construct MultiTypeExperiment, and the one after will deprecate the class entirely
Differential Revision: D91920991