enable adding derived parameters to an experiment with existing trials #4888
+245
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook#4888) Summary: This enables adding `DerivedParameter`s to an experiment with existing trials. These `DerivedParameter`s do not have a `backfill_value` as `RangeParameter`s do, but rather, their values are compute in `FillMissingParameters` based on the values of the other parameters. Differential Revision: D92753331
sdaulton
force-pushed
the
export-D92753331
branch
from
4f2f478 to
3dc496c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4888 +/- ##
==========================================
- Coverage 96.76% 96.76% -0.01%
==========================================
Files 593 593
Lines 62035 62065 +30
==========================================
+ Hits 60030 60055 +25
- Misses 2005 2010 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This enables adding
DerivedParameters to an experiment with existing trials. TheseDerivedParameters do not have abackfill_valueasRangeParameters do, but rather, their values are compute inFillMissingParametersbased on the values of the other parameters.Differential Revision: D92753331