Add granular CMake targets with generate_cmake.py#590
Open
afrind wants to merge 1 commit intofacebook:mainfrom
Open
Add granular CMake targets with generate_cmake.py#590afrind wants to merge 1 commit intofacebook:mainfrom
afrind wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Add granular CMake targets for proxygen following the same pattern as mvfst, fizz, and wangle. This introduces: - generate_cmake.py: Generates CMakeLists.txt files from BUCK/TARGETS files - ProxygenFunctions.cmake: Infrastructure for proxygen_add_library() macro - ProxygenCompatAliases.cmake: Backward compatibility aliases for moxygen - Granular libraries under lib/ with proper dependency tracking - Lint integration for keeping CMake in sync with BUCK The monolithic proxygen::proxygen target is preserved for backward compatibility. Dependencies now come naturally from BUCK files rather than blanket variables. Manual CMakeLists.txt files (httpserver, httpclient/samples) have been updated to use proxygen_add_library where appropriate. Differential Revision: D91009064
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add granular CMake targets for proxygen following the same pattern as mvfst,
fizz, and wangle. This introduces:
The monolithic proxygen::proxygen target is preserved for backward compatibility.
Dependencies now come naturally from BUCK files rather than blanket variables.
Manual CMakeLists.txt files (httpserver, httpclient/samples) have been updated
to use proxygen_add_library where appropriate.
Differential Revision: D91009064