Remove useTurboModules assertion from ReactHostImpl.getOrCreateStartTask#56927
Closed
mdvacca wants to merge 3 commits into
Closed
Remove useTurboModules assertion from ReactHostImpl.getOrCreateStartTask#56927mdvacca wants to merge 3 commits into
mdvacca wants to merge 3 commits into
Conversation
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
Summary: The `enableFabricRenderer` feature flag has been removed; it was always set to true on the canary release stage and there are no remaining callers (all inlined in earlier diffs of this stack). This diff: - Removes the `enableFabricRenderer` entry from `ReactNativeFeatureFlags.config.js`. - Updates the description of `enableBridgelessArchitecture` (which referenced `enableFabricRenderer`). - Regenerates the codegen output: the 7 Kotlin `generated` files in `ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/`, the C++ headers and implementations under `ReactCommon/react/featureflags/` and `ReactCommon/react/nativemodule/featureflags/`, the JNI bridge under `ReactAndroid/src/main/jni/react/featureflags/`, and the JS modules under `src/private/featureflags/`. The flag is in the `com.facebook.react.internal.featureflags` package and is excluded from `ReactAndroid.api` tracking; no API metadata regeneration is needed. Behavior is unchanged. Changelog: [Android][Removed] - Remove `enableFabricRenderer` feature flag — Fabric is now always enabled Reviewed By: javache Differential Revision: D105232652
Summary: The `useTurboModules` flag is being deleted; it always returns true on the canary release stage. The DEBUG-gated assertion in `ReactHostImpl.getOrCreateStartTask()` is therefore tautological — remove it. The `enableBridgelessArchitecture` assertion immediately above stays. Behavior is unchanged. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D105718211
meta-cla
Bot
added
the
CLA Signed
|
@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105718211. |
|
This pull request has been merged in 26f313b. |
Collaborator
|
This pull request was successfully merged by @mdvacca in 26f313b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
useTurboModulesflag is being deleted; it always returns true on the canary release stage. The DEBUG-gated assertion inReactHostImpl.getOrCreateStartTask()is therefore tautological — remove it.The
enableBridgelessArchitectureassertion immediately above stays.Behavior is unchanged.
Changelog:
[Internal]
Reviewed By: fkgozali
Differential Revision: D105718211