Add GLOG_USE_GLOG_EXPORT for glog 0.7+ compatibility#248
Closed
afrind wants to merge 1 commit intofacebook:mainfrom
Closed
Add GLOG_USE_GLOG_EXPORT for glog 0.7+ compatibility#248afrind wants to merge 1 commit intofacebook:mainfrom
afrind wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: glog 0.7+ requires the preprocessor define `GLOG_USE_GLOG_EXPORT` before including its headers. Add `add_compile_definitions(GLOG_USE_GLOG_EXPORT)` after `find_package(Glog REQUIRED)` in the wangle CMakeLists.txt. The define is harmless on older glog versions. Differential Revision: D93321000
|
This pull request has been merged in 5082ae0. |
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 14, 2026
Summary: X-link: facebook/wangle#248 glog 0.7+ requires the preprocessor define `GLOG_USE_GLOG_EXPORT` before including its headers. Add `add_compile_definitions(GLOG_USE_GLOG_EXPORT)` after `find_package(Glog REQUIRED)` in the wangle CMakeLists.txt. The define is harmless on older glog versions. Reviewed By: mjoras Differential Revision: D93321000 fbshipit-source-id: 9a4ed1a4aca2a6773eb7162c55f97c8b39517fb7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: glog 0.7+ requires the preprocessor define
GLOG_USE_GLOG_EXPORTbefore including its headers. Addadd_compile_definitions(GLOG_USE_GLOG_EXPORT)afterfind_package(Glog REQUIRED)in the wangle CMakeLists.txt. The define is harmless on older glog versions.Differential Revision: D93321000