This repository was archived by the owner on Jan 1, 2025. It is now read-only.
fix UserWarning for floor division in position encoder#159
Open
jveitchmichaelis wants to merge 1 commit intofacebookresearch:mainfrom
Open
fix UserWarning for floor division in position encoder#159jveitchmichaelis wants to merge 1 commit intofacebookresearch:mainfrom
jveitchmichaelis wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Torch currently throws a UserWarning for a division op in the position encoding module.
Using the
truncrounding mode retains current behaviour, but presumablyfloorwould also be fine here asdim_tshould never be negative.EDIT: (There may be more places that I haven't triggered...!)