Serialiser and Zeromq changes to support rda3 client implementation

src/core/include/SpinWait.hpp

@@ -1,6 +1,7 @@
 #ifndef SPIN_WAIT_HPP
 #define SPIN_WAIT_HPP
 
+#include <atomic>
 #include <cstdint>
 #include <functional>
 #include <thread>
@@ -67,12 +68,12 @@
     void reset() noexcept { _count = 0; }
 
     template<typename T>
-    requires std::is_nothrow_invocable_r_v<bool, T>
+        requires std::is_nothrow_invocable_r_v<bool, T>
     bool
     spinUntil(const T &condition) const { return spinUntil(condition, -1); }
 
     template<typename T>
-    requires std::is_nothrow_invocable_r_v<bool, T>
+        requires std::is_nothrow_invocable_r_v<bool, T>
     bool
     spinUntil(const T &condition, std::int64_t millisecondsTimeout) const {
         if (millisecondsTimeout < -1) {
@@ -111,13 +112,13 @@
     SPIN_WAIT        _spin_wait;
 
 public:
-    AtomicMutex()                    = default;
-    AtomicMutex(const AtomicMutex &) = delete;
+    AtomicMutex()                               = default;
+    AtomicMutex(const AtomicMutex &)            = delete;
     AtomicMutex &operator=(const AtomicMutex &) = delete;
 
     //
     void lock() {
         while (_lock.test_and_set(std::memory_order_acquire)) {
             if constexpr (requires { _spin_wait.spin_once(); }) {
                 _spin_wait.spin_once();
             }
@@ -126,7 +127,7 @@
             _spin_wait.reset();
         }
     }
     void unlock() { _lock.clear(std::memory_order::release); }
 };
 
 } // namespace opencmw

src/core/include/Topic.hpp

@@ -103,11 +103,13 @@ struct Topic {
         return opencmw::URI<STRICT>::factory().path(_service).setQuery({ _params.begin(), _params.end() }).build();
     }
 
-    std::string toZmqTopic() const {
+    std::string toZmqTopic(const bool delimitWithPound = true) const {
         using namespace std::string_literals;
         std::string zmqTopic = _service;
         if (_params.empty()) {
-            zmqTopic += "#"s;
+            if (delimitWithPound) {
+                zmqTopic += "#"s;
+            }
             return zmqTopic;
         }
         zmqTopic += "?"s;
@@ -123,7 +125,9 @@ struct Topic {
             }
             isFirst = false;
         }
-        zmqTopic += "#"s;
+        if (delimitWithPound) {
+            zmqTopic += "#"s;
+        }
         return zmqTopic;
     }
 

src/core/include/opencmw.hpp

@@ -779,47 +779,11 @@ inline constexpr void diffView(std::ostream &os, const T &lhs, const T &rhs) {
 
 template<typename T>
 static std::errc parseNumber(std::string_view str, T &number) {
-    // wrapper for missing std::from_chars() support for floating point types in clang < 20
-    // Note that this implementation is intolerant to trailing non-number junk in the given string.
-#ifdef __clang__
-    if constexpr (std::is_same_v<T, float>) {
-        char *endPtr = nullptr;
-        float value  = std::strtof(str.data(), &endPtr);
-        if (endPtr == str.data() + str.size() && errno == 0) {
-            number = value;
-            return std::errc{};
-        }
-        return std::errc::invalid_argument;
-    } else if constexpr (std::is_same_v<T, double>) {
-        char  *endPtr = nullptr;
-        double value  = std::strtod(str.data(), &endPtr);
-        if (endPtr == str.data() + str.size() && errno == 0) {
-            number = value;
-            return std::errc{};
-        }
-        return std::errc::invalid_argument;
-    } else if constexpr (std::is_same_v<T, long double>) {
-        char       *endPtr = nullptr;
-        long double value  = std::strtold(str.data(), &endPtr);
-        if (endPtr == str.data() + str.size() && errno == 0) {
-            number = value;
-            return std::errc{};
-        }
-        return std::errc::invalid_argument;
-    } else {
-        const auto rc = std::from_chars(str.data(), str.data() + str.size(), number);
-        if (rc.ptr == str.data() + str.size() && rc.ec == std::errc{}) {
-            return std::errc{};
-        }
-        return rc.ec == std::errc{} ? std::errc::invalid_argument : rc.ec;
-    }
-#else
     const auto rc = std::from_chars(str.data(), str.data() + str.size(), number);
     if (rc.ptr == str.data() + str.size() && rc.ec == std::errc{}) {
         return std::errc{};
     }
     return rc.ec == std::errc{} ? std::errc::invalid_argument : rc.ec;
-#endif
 }
 
 } // namespace opencmw

src/serialiser/include/IoSerialiser.hpp

@@ -147,10 +147,18 @@
     }
 };
 
+template<std::size_t N, refl::const_string<N> string>
+constexpr const char *sanitizeFieldName() {
+    if constexpr (N > 2 && string.data[0] == 'x' && string.data[1] == '_') {
+        return string.c_str() + 2;
+    }
+    return string.c_str();
+}
+
 template<ReflectableClass T>
 OPENCMW_FORCEINLINE int32_t findMemberIndex(const std::string_view &fieldName) noexcept {
     static constexpr ConstExprMap<std::string_view, int32_t, refl::reflect<T>().members.size> m{ refl::util::map_to_array<std::pair<std::string_view, int32_t>>(refl::reflect<T>().members, [](auto field, auto index) {
-        return std::pair<std::string_view, int32_t>(field.name.c_str(), index);
+        return std::pair<std::string_view, int32_t>(sanitizeFieldName<field.name.size, field.name>(), index);
     }) };
     return m.at(fieldName, -1);
 }
@@ -200,15 +208,15 @@
             using UnwrappedMemberType = std::remove_reference_t<decltype(getAnnotatedMember(unwrapPointer(fieldValue)))>;
             if constexpr (isReflectableClass<UnwrappedMemberType>()) { // nested data-structure
                 const auto            subfields            = getNumberOfNonNullSubfields(getAnnotatedMember(unwrapPointer(fieldValue)));
-                FieldDescription auto field                = newFieldHeader<protocol, writeMetaInfo>(buffer, member.name.c_str(), parent.hierarchyDepth + 1, FWD(fieldValue), subfields);
+                FieldDescription auto field                = newFieldHeader<protocol, writeMetaInfo>(buffer, sanitizeFieldName<member.name.size, member.name>(), parent.hierarchyDepth + 1, FWD(fieldValue), subfields);
                 const std::size_t     posSizePositionStart = FieldHeaderWriter<protocol>::template put<writeMetaInfo>(buffer, field, START_MARKER_INST);
                 const std::size_t     posStartDataStart    = buffer.size();
                 serialise<protocol, writeMetaInfo>(buffer, getAnnotatedMember(unwrapPointer(fieldValue)), field); // do not inspect annotation itself
                 FieldHeaderWriter<protocol>::template put<writeMetaInfo>(buffer, field, END_MARKER_INST);
                 updateSize<protocol>(buffer, posSizePositionStart, posStartDataStart);
                 return;
             } else { // field is a (possibly annotated) primitive type
-                FieldDescription auto field = newFieldHeader<protocol, writeMetaInfo>(buffer, member.name.c_str(), parent.hierarchyDepth + 1, fieldValue, 0);
+                FieldDescription auto field = newFieldHeader<protocol, writeMetaInfo>(buffer, sanitizeFieldName<member.name.size, member.name>(), parent.hierarchyDepth + 1, fieldValue, 0);
                 FieldHeaderWriter<protocol>::template put<writeMetaInfo>(buffer, field, fieldValue);
             }
         }
@@ -217,10 +225,10 @@
 } // namespace detail
 
 template<SerialiserProtocol protocol, const bool writeMetaInfo = true>
 constexpr void serialise(IoBuffer &buffer, ReflectableClass auto const &value) {
     putHeaderInfo<protocol>(buffer);
     const auto        subfields            = detail::getNumberOfNonNullSubfields(value);
-    auto              field                = detail::newFieldHeader<protocol, writeMetaInfo>(buffer, refl::reflect(value).name.c_str(), 0, value, subfields);
+    auto              field                = detail::newFieldHeader<protocol, writeMetaInfo>(buffer, sanitizeFieldName<refl::reflect<std::remove_reference_t<decltype(value)>>().name.size, refl::reflect<std::remove_reference_t<decltype(value)>>().name>(), 0, value, subfields);
     const std::size_t posSizePositionStart = FieldHeaderWriter<protocol>::template put<writeMetaInfo>(buffer, field, START_MARKER_INST);
     const std::size_t posStartDataStart    = buffer.size();
     detail::serialise<protocol, writeMetaInfo>(buffer, value, field);
@@ -338,7 +346,7 @@
                 field.intDataType = IoSerialiser<protocol, START_MARKER>::getDataTypeId();
             } else {
                 constexpr int requestedType = IoSerialiser<protocol, MemberType>::getDataTypeId();
-                if (requestedType != field.intDataType) { // mismatching data-type
+                if (requestedType != field.intDataType && requestedType != IoSerialiser<protocol, OTHER>::getDataTypeId()) { // mismatching data-type
                     moveToFieldEndBufferPosition(buffer, field);
                     if constexpr (check == ProtocolCheck::IGNORE) {
                         return; // don't write -> skip to next
@@ -387,7 +395,7 @@
                 if constexpr (isReflectableClass<MemberType>()) {
                     buffer.set_position(field.headerStart); // reset buffer position for the nested deserialiser to read again
                     field.hierarchyDepth++;
-                    field.fieldName = member.name.c_str(); // N.B. needed since member.name is referring to compile-time const string
+                    field.fieldName = sanitizeFieldName<member.name.size, member.name>(); // N.B. needed since member.name is referring to compile-time const string
                     deserialise<protocol, check>(buffer, unwrapPointerCreateIfAbsent(member(value)), info, field);
                     field.hierarchyDepth--;
                     field.subfields = previousSubFields - 1;