Attempt to better support badges w/ GitLab#392
Open
dbroemmel wants to merge 4 commits intofair-software:mainfrom
Open
Attempt to better support badges w/ GitLab#392dbroemmel wants to merge 4 commits intofair-software:mainfrom
dbroemmel wants to merge 4 commits intofair-software:mainfrom
Conversation
GitLab supports including badges within the project settings, outside any README files. GitLab also has an API call to get a collection of all badges. This commit adds this API call and returned json blob to be checked for badges apart from the README files. This should not affect any github projects.
Adding a check for GitLab project badges opens up many different possibilities where/how to check for the howfairis badge, trying to cover what comes to mind. This commit also adds a single test for one such case (would all have to be covered?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
and provided solution was discussedList of related issues or pull requests
Briefly describe the changes made in this pull request
Next to READMEs as source for displayed badges, a GitLab-API call will obtain a list of project badges in case the platform is 'GitLab'. The current badge for howfairis will be compared to badges in both sources for badges, recommendations on what to change/update hopefully cover all combinations.
Two test cases have been amended/extended to cover at least the basics.
Additional Notes
No documentation has been changed, I guess more tests could be added as well.
Instructions to review the pull request
Keep what you need from below, extend as necessary