open data folder from other directory, relate #106 by Shine226 · Pull Request #181 · fairnessforensics/wiggum

Shine226 · 2020-05-11T20:19:57Z

No description provided.

brownsarahm · 2020-05-11T20:31:03Z

+        elif type(data) == list and meta ==None and results ==None:
+            # if files are uploaded from wiggum-app
+            filename = ''
+            for file in data:
+                filename = file.filename
+                if ('/' in filename):
+                    # if file name contains '/', Wiggum runs in Windows system
+                    # remove the directory and only use the file name
+                    filename = filename.split('/')[1]
+
+                if filename == data_csv:
+                    data = file
+                elif filename == meta_csv:
+                    meta = file
+                elif filename == result_csv:
+                    results = file
+                elif filename == trend_json:
+                    trends = file


is there no way to do this on the app side? like have the upload step put the files in a temp directory and then pass that to the initialize function?

That will be more complicated.

but I think better and possibly more on the path to allowing the user to download and save their results where they would like.

brownsarahm · 2020-05-11T20:32:01Z

+                with open(trends, 'r') as tjson:
+                    trend_content = json.load(tjson)
+            elif type(trends) is FileStorage:
+                trend_content = json.load(trends)


why did you not use the safe with open format for this?

Because the trends are already a FileStorage type, can't use open function.

brownsarahm · 2020-05-11T20:32:41Z

 DEBUG=True
 SECRET_KEY="4zNNYuWQjNCHoCFrhEKqUDLB1Z5xGl2W/Yliy63tD8po9qOQ0YjPum5OaSDnPvNvB1eLzany73EHJfFlYEov1g=="
 SERVER_NAME="127.0.0.1:5000"
+SAVE_FOLDER="data/"


does this / resolve correctly on windows and mac?

No, that is moving the hard code directory from controller.py to config.py.

then #95 is not closed, becase you are making the config as a place the user should do some setup, so:

make it a template and provide instructions for the user

make sure that where you use this you use something that safely puts the / or \ as appropriate per os (eg os.path.join

brownsarahm · 2020-08-06T19:44:22Z

@Shine226 you should resovle the conflicts in this branch and get it ready to merge

Shine226 · 2020-08-06T20:33:21Z

@brownsarahm I don't remember what is the conflicts in this branch.

found error

brownsarahm · 2020-09-10T13:46:44Z

When I click the save button I get the following traceback on the iristest data with pearson correlation and linear regression.

Traceback (most recent call last):
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 2464, in __call__
    return self.wsgi_app(environ, start_response)
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 2450, in wsgi_app
    response = self.handle_exception(e)
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 1867, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/opt/anaconda3/lib/python3.8/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/opt/anaconda3/lib/python3.8/site-packages/wiggum_app/controller.py", line 208, in main
    models.compress_files(directory)
  File "/opt/anaconda3/lib/python3.8/site-packages/wiggum_app/models.py", line 319, in compress_files
    zipf = zipfile.ZipFile(file_path, 'w', zipfile.ZIP_DEFLATED)
  File "/opt/anaconda3/lib/python3.8/zipfile.py", line 1250, in __init__
    self.fp = io.open(file, filemode)
FileNotFoundError: [Errno 2] No such file or directory: 'wiggum_app/download/data.zip

and then the same as a browser side error on clicking download.

Also minor formatting issue, when the window is small,

Running from wiggum-app

Shine226 requested a review from brownsarahm May 11, 2020 20:20

brownsarahm marked this pull request as draft May 11, 2020 20:25

brownsarahm reviewed May 11, 2020

View reviewed changes

brownsarahm changed the base branch from master to main August 6, 2020 19:42

Shine226 added 3 commits August 7, 2020 13:08

open data folder from other directory, relate #106

9a77682

sending files in tester.post

34bfa34

Solve the conflicts for merging

c962091

Shine226 force-pushed the open_folder branch from 6465927 to c962091 Compare August 7, 2020 18:10

add download feature, relate #106

df532d9

Shine226 marked this pull request as ready for review September 9, 2020 20:25

brownsarahm previously approved these changes Sep 10, 2020

View reviewed changes

Shine226 added 6 commits September 10, 2020 11:22

Add download folder

6139fdf

Solve the path error when downloading

8a0416e

Running from wiggum-app

Delete data.zip

d333c9c

Create README.rst

f447994

Delete README.rst

cccb6a6

Create .gtikeep

782e583

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

open data folder from other directory, relate #106#181

open data folder from other directory, relate #106#181
Shine226 wants to merge 10 commits into
mainfrom
open_folder

Shine226 commented May 11, 2020

Uh oh!

brownsarahm May 11, 2020

Uh oh!

Shine226 May 11, 2020

Uh oh!

brownsarahm May 11, 2020

Uh oh!

brownsarahm May 11, 2020

Uh oh!

Shine226 May 11, 2020

Uh oh!

brownsarahm May 11, 2020

Uh oh!

Shine226 May 11, 2020

Uh oh!

brownsarahm May 11, 2020

Uh oh!

brownsarahm commented Aug 6, 2020

Uh oh!

Shine226 commented Aug 6, 2020

Uh oh!

brownsarahm commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Shine226 commented May 11, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brownsarahm commented Aug 6, 2020

Uh oh!

Shine226 commented Aug 6, 2020

Uh oh!

brownsarahm commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants