Nextjs css import fix#96
Open
kayvaninvemo wants to merge 2 commits intofarminf:masterfrom
Open
Conversation
…t. This will fix the issue on nextjs build
ChanderShekharKestone
left a comment
ChanderShekharKestone
left a comment
There was a problem hiding this comment.
How to reslove inmy next js app.
Author
We are waiting for the PR to be merged and published. Meanwhile you can check this one https://github.com/kayvaninvemo/pannellum-react/tree/master |
ChanderShekharKestone
approved these changes
May 31, 2022
|
Any idea when this will be merged? |
GETTING ERROR after creating a patch getting so much error next's 12 |
Author
|
This is working on one of our production env. And I could not find the error. With React 17 and Nextjs 12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In NextJS if the library imports a css, the build fails. So it is better to let the user to import the css. As this is a breaking change, we need to change a major version.