Fix clippy warnings: box large enum variant in template-app#4345
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Fix clippy warnings: box large enum variant in template-app#4345devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Box the EnhanceUser variant which is at least 264 bytes, much larger than the second-largest variant at 48 bytes. Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
clippy::large_enum_variantwarning incrates/template-app. TheEnhanceUservariant is at least 264 bytes, while the second-largest variant is 48 bytes. Wrapping it inBoxreduces the enum's stack size.Changes:
Template::EnhanceUser(EnhanceUser)→Template::EnhanceUser(Box<EnhanceUser>)render()match arm to dereference:&t→&*tReview & Testing Checklist for Human
Template::EnhanceUser(...)in macOS-only packages (excluded from clippy on Linux). These will needBox::new(...)wrapping to compile. Grep forTemplate::EnhanceUser(across the full codebase including Tauri plugins.specta::Typederive handlesBox<EnhanceUser>correctly — confirm the generated TypeScript bindings still produce the expected type (not wrapping in an extra layer). Runtauri-spectatype generation and diff the output.Box<T>should be transparent for serde, but worth a quick sanity check thatTemplatedeserializes the same as before.Notes