-
Notifications
You must be signed in to change notification settings - Fork 74
Set dims to longitude, latitude if projection passed #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.0-dev
Are you sure you want to change the base?
Conversation
|
We're breaking some backward compatibility by returning new set of |
leouieda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, probably best to wait for 2.0. We should start a branch to gather these PRs.
|
I've changed the base here to |
Co-authored-by: Leonardo Uieda <leouieda@gmail.com>
Add one more test where projection argument is omitted.
Make
BaseGridder.grid,BaseGridder.scatterandBaseGridder.profileto use("latitude", "longitude")as defaultdimsif aprojectionis passed.After fatiando/harmonica#233
Reminders:
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rstand the base__init__.pyfile for the package.AUTHORS.mdfile (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.