⚙️ Core: Refactor AllocationStrategy to use ClinicalTrialError #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 The Violation:
AllocationStrategyusedStringfor error handling (Primitive Obsession), preventing programmatic handling of errors likeInsufficientSampleSizeorInvalidData.🛠️ The Fix: Enforced Typed Errors. Updated
AllocationStrategyto returnResult<Vec<Group>, ClinicalTrialError>. UpdatedSimpleRandomizerandBlockRandomizerto match.📉 Debt Reduction: Removed ad-hoc string error construction in the core strategy.
🧪 Integrity: Verified with
cargo testandcargo clippy. Logic preserved, backward compatibility maintained via legacy adapter functions.PR created automatically by Jules for task 941870691016806650 started by @fderuiter