Skip to content

Conversation

@fderuiter
Copy link
Owner

🔧 The Violation: AllocationStrategy used String for error handling (Primitive Obsession), preventing programmatic handling of errors like InsufficientSampleSize or InvalidData.
🛠️ The Fix: Enforced Typed Errors. Updated AllocationStrategy to return Result<Vec<Group>, ClinicalTrialError>. Updated SimpleRandomizer and BlockRandomizer to match.
📉 Debt Reduction: Removed ad-hoc string error construction in the core strategy.
🧪 Integrity: Verified with cargo test and cargo clippy. Logic preserved, backward compatibility maintained via legacy adapter functions.


PR created automatically by Jules for task 941870691016806650 started by @fderuiter

Replaced `Result<..., String>` with `Result<..., ClinicalTrialError>` in the `AllocationStrategy` trait to enforce typed error handling and eliminate primitive obsession. Updated implementations and preserved legacy API via adapters.

Co-authored-by: fderuiter <127706008+fderuiter@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter closed this Jan 26, 2026
@fderuiter fderuiter deleted the refactor/clinical-trials-errors-941870691016806650 branch January 26, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants