Skip to content

Conversation

@fderuiter
Copy link
Owner

This PR refactors the climate and clinical_trials modules to improve error handling and safety.

Key Changes:

  1. Climate Module:

    • Added ClimateError enum for structured error handling.
    • Updated mse_loss and earth_movers_distance to return Result instead of panicking on dimension mismatch or invalid data.
    • Updated Cera::new and CeraTrainer::train to propagate errors.
    • Fixed unwrap() usage in earth_movers_distance by using total_cmp.
  2. Clinical Trials Module:

    • Updated AllocationStrategy trait to return Result<Vec<Group>, ClinicalTrialError> instead of Result<..., String>.
    • Refactored SimpleRandomizer and BlockRandomizer to implementation this new signature.
    • Kept deprecated functions compatible by mapping errors to String.

These changes eliminate several potential panics and replace "stringly typed" errors with proper Rust error types, aligning with the project's refactoring goals.


PR created automatically by Jules for task 9569915157609649907 started by @fderuiter

… errors

- Introduced `ClimateError` enum in `math_explorer/src/climate/error.rs`.
- Refactored `mse_loss` and `earth_movers_distance` to return `Result<f32, ClimateError>`.
- Refactored `Cera::new` and `CeraTrainer::train` to propagate `ClimateError`.
- Refactored `AllocationStrategy` in `clinical_trials` to return `Result<..., ClinicalTrialError>`.
- Updated `SimpleRandomizer` and `BlockRandomizer` to use `ClinicalTrialError`.
- Updated legacy wrappers in `clinical_trials` to map errors to String for backward compatibility.
- Verified all changes with tests.

Co-authored-by: fderuiter <127706008+fderuiter@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter closed this Jan 26, 2026
@fderuiter fderuiter deleted the refactor/climate-trials-error-handling-9569915157609649907 branch January 26, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants