⚙️ Core: Refactor Gillespie Algorithm to Strategy Pattern #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 The Violation
The
gillespie_step_timefunction inmath_explorer/src/epidemiology/stochastic.rsviolated several "Systems Core" principles:rand::thread_rng(), making it impossible to seed for deterministic testing.🛠️ The Fix
I applied the Strategy Pattern and Dependency Inversion:
StochasticSystem<State>trait that allows any model to define its propensities (rates) and reaction logic.GillespieSolver<R: Rng>that accepts any RNG strategy (e.g.,StdRng,ThreadRng).StochasticSystemfor the existingSIRModel.gillespie_step_timefunction.📉 Debt Reduction
thread_rng.🧪 Integrity
cargo testsuccessfully.test_gillespie_solver_deterministicwhich verifies the solver behavior using a fixed seed, ensuring logic is preserved and correct.SIRModelimplementation matches the expected reaction dynamics.PR created automatically by Jules for task 14656697529283794320 started by @fderuiter