Skip to content

🎨 Palette: Add typed error handling to Climate module #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fderuiter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add typed error handling to Climate module #358

fderuiter wants to merge 1 commit into from

Conversation

@fderuiter
Copy link
Owner

@fderuiter fderuiter commented Jan 27, 2026

🎨 Palette: Improved error handling in Climate module.

💡 What:

  • Created math_explorer/src/climate/error.rs with ClimateError.
  • Updated math_explorer/src/climate/loss.rs to return Result instead of panicking.
  • Updated math_explorer/src/climate/training.rs to propagate errors.
  • Updated tests and examples.

🎯 Why:

  • Previous implementation panicked on shape mismatches, which is bad DX for a library.
  • Typed errors allow callers to handle failures gracefully.
  • total_cmp prevents panics on NaN during sorting in EMD calculation.

♿ Accessibility/UX:

  • Improved Developer Experience (DX) by providing clear error messages and avoiding runtime crashes.

PR created automatically by Jules for task 13817827108656443905 started by @fderuiter

@google-labs-jules @fderuiter
Refactor climate module to use typed ClimateError instead of panics
e6b9648 
This change introduces `ClimateError` to handle shape mismatches and invalid configurations gracefully.
- Replaced `assert_eq!` panics in `mse_loss` and `earth_movers_distance` with `Result<f32, ClimateError>`.
- Updated `CeraTrainer::train` to propagate errors.
- Improved `earth_movers_distance` sorting safety using `f32::total_cmp`.
- Updated tests and documentation to reflect the API changes.

Co-authored-by: fderuiter <127706008+fderuiter@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

google-labs-jules bot commented Jan 27, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fderuiter