Add ElysiaJS option to fedify init
#496
Conversation
Summary of ChangesHello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for ElysiaJS to the fedify init command. The changes look good overall, introducing a new web framework option, its configuration, and a template file. I've identified a critical issue with a dependency version that would break installation, and I've also suggested improvements to the new template for better flexibility and to the constants file for better maintainability. Addressing these points will make the new feature more robust and align it with existing patterns in the codebase.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Fix joinDepsReg to properly handle dependencies that already contain registry prefixes. When a dependency value included a prefix like "npm:elysia@^1.3.6", the function was incorrectly prepending the name again, creating invalid specifiers like "jsr:elysia@npm:elysia@^1.3.6" in deno.json imports. Now checks if version already starts with "npm:" or "jsr:" and uses it as-is, otherwise constructs the spec from name and version. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Split Elysia template into runtime-specific versions (Deno, Bun, Node.js) to properly handle different runtime APIs and configurations. Deno uses Deno.serve() API, Bun and Node use Elysia's .listen() method with @elysiajs/node adapter for Node. Update webframeworks.ts to support all package managers (deno, bun, npm, yarn, pnpm) with appropriate dependencies and configurations for each runtime. Add --allow-env and --allow-net flags for Deno tasks since Elysia requires environment access. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Update CLI documentation to include Elysia as a web framework option. Add installation instructions for all package managers in the Elysia integration section of the manual.
issues-auto-labeler
bot
added
component/cli
1 participant
Summary
Add
ElysiaJSoption tofedify initwhen user choose bun as runtime.Related Issue
fedify init#460Changes
elysiaoption tofedify init.Benefits
The user can make the Elysia app with Fedify easily.
Checklist
deno task test-allon your machine?Additional Notes
Due to Elysia being based on the Bun, it's unable to test with
deno task test-init.