Bugfix/hms hamon#141
Open
sclaw wants to merge 2 commits into
Open
Conversation
sclaw
requested review from
ngoXminh and
sray014
and removed request for
ngoXminh
🔍 SonarQube Analysis ResultsSummary:
📋 Detailed Reports Available📥 Download Full Report - Click "Artifacts" section The detailed report includes:
|
🔍 Vulnerabilities of
|
| digest | sha256:81de315784c0b309df214aa8b87a3a907ca0254afb05615f078b5fd7e39bc59d |
| vulnerabilities |     |
| platform | linux/amd64 |
| size | 408 MB |
| packages | 319 |
📦 Base Image ubuntu:24.04
| also known as |
|
| digest | sha256:e21f810fa78c09944446ec02048605eb3ab1e4e2e261c387ecc7456b38400d79 |
| vulnerabilities |   |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #138. The _process_hamon_coefficient function was updated to not raise a UnboundLocalError. It now returns None instead, and handling for that None value was added.
Future work should investigate whether that Hamon handling was appropriate to add in the first place. Perhaps it should have been handled in the regular _process_keyval_pairs function.