Skip to content

Conversation

@leoschwarz
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

📝 "TODO" Changes Detected

Summary: ➕ 16 "TODO"s added

➕ Added "TODO"s (16)

  • bfabric_app_runner/src/bfabric_app_runner/output_registration/annotation_table.py:71: # TODO the schema handling could maybe be relaxed a tiny bit
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/register.py:245: # TODO and now we need to handle this maybe with the old logic of save/update from savedataset
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/register.py:186: # TODO maybe the naming "created" is a bit confusing, because it could have existed beforehand
  • bfabric_app_runner/src/bfabric_app_runner/specs/outputs_spec.py:51: # TODO deprecate!
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/annotation_table.py:30: # TODO maybe this should be a generic function somewhere, it's duplicated with input specs probably!
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/register.py:243: # TODO we should also check if there is id already
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/annotation_table.py:50: # TODO the resource mapping has some challenges if it's not a model regarding mis-use non-canonical paths,
  • bfabric_app_runner/src/bfabric_app_runner/specs/outputs/annotations.py:44: # TODO since there is only one output annotation, we cannot set the default value yet, because
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/register.py:274: # TODO and here we create the dataset mapping
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/register.py:246: # TODO but it will need some logic for handling the existing dataset already
  • bfabric_app_runner/src/bfabric_app_runner/specs/outputs_spec.py:96: # TODO although the main scenario where this could be a problem is when store_folder_path is used and maybe we
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/register.py:247: # TODO the final step will be attaching this dataset to the workunit
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/annotation_table.py:45: # TODO check if accessing store_entry_path like this is robust enough (see comment below)
  • bfabric_app_runner/src/bfabric_app_runner/specs/outputs/annotations.py:18: # TODO decide if this is the correct place or it should be a level higher
  • bfabric_app_runner/src/bfabric_app_runner/specs/outputs/annotations.py:38: # TODO None vs empty string
  • bfabric_app_runner/src/bfabric_app_runner/output_registration/register.py:220: # TODO register the dataset... now this gets tricky, how should we handle the case when there is existing dataset

This comment is automatically updated when "TODO" changes are detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants