Open
Conversation
config('rfa.github_repo') is never read anywhere in the codebase. The
real GitHub repo for the auto-updater is configured in
config/nativephp.php under a different env var (GITHUB_REPO), as noted
in .github/CLAUDE.md. Leaving this entry around suggested the variable
controlled the updater and made it harder to reason about release
configuration.
composer.json requires php ^8.4 and laravel/framework ^13.0 (lock at 13.4.0), but README still listed PHP 8.3+ and Laravel 12. A contributor following the README on PHP 8.3 would hit a confusing platform error on composer install.
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe PR extracts the hardcoded active-project cache key into a public constant on ChangesActive Project Cache Key Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ScreenshotsUpdated for
|
The 'rfa.active-project-id' literal was hand-copied across four files: HandleMenuItemClicked reads it, and three Blade pages (⚡review-page, ⚡context-page, ⚡select-repo-page) write or clear it. A typo in any writer would silently break the native menu's "Show Context" entry with no diagnosable trail. Hoisting the key onto HandleMenuItemClicked::ACTIVE_PROJECT_CACHE_KEY makes the renderer→main-process channel discoverable from one grep and typo-resistant.
fgilio
force-pushed
the
claude/fix-maintainability-debt-xn8Yx
branch
from
e86b87b to
b841a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config('rfa.github_repo') is never read anywhere in the codebase. The
real GitHub repo for the auto-updater is configured in
config/nativephp.php under a different env var (GITHUB_REPO), as noted
in .github/CLAUDE.md. Leaving this entry around suggested the variable
controlled the updater and made it harder to reason about release
configuration.
Summary by CodeRabbit
Documentation
Refactor
Chores
github_repoconfiguration option.