chore(deps): bump @sentry/profiling-node from 10.36.0 to 10.39.0#497
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
chore(deps): bump @sentry/profiling-node from 10.36.0 to 10.39.0#497dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Analysis: Run #1025
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
1060453 to
fe0e7c9
Compare
Bumps [@sentry/profiling-node](https://github.com/getsentry/sentry-javascript) from 10.36.0 to 10.39.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@10.36.0...10.39.0) --- updated-dependencies: - dependency-name: "@sentry/profiling-node" dependency-version: 10.39.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
fe0e7c9 to
d86231f
Compare
Analysis: Run #1030
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
Comment on lines
32
to
+33
| "@sentry/node": "10.36.0", | ||
| "@sentry/profiling-node": "10.36.0", | ||
| "@sentry/profiling-node": "10.39.0", |
There was a problem hiding this comment.
Bug: The @sentry/node and @sentry/profiling-node packages have mismatched versions. This will cause the profiling integration to fail to initialize, disabling the feature.
Severity: MEDIUM
Suggested Fix
Update the version of @sentry/node in backend/package.json and mcp-server/package.json to match the version of @sentry/profiling-node, which is 10.39.0. This will ensure both packages are compatible as required by Sentry.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: backend/package.json#L32-L33
Potential issue: The `package.json` specifies `@sentry/node` at version `10.36.0` while
`@sentry/profiling-node` is at `10.39.0`. Sentry's documentation explicitly states that
the version of the profiling package must exactly match the main SDK package. This
mismatch will cause the dynamic import of `nodeProfilingIntegration` to fail. Although
the application has a `try-catch` block to prevent a crash, this will result in Sentry
profiling being silently disabled in production, and an error will be logged. The
intended performance monitoring will not function.
Did we get this right? 👍 / 👎 to inform future reviews.
Analysis: Run #1033
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @sentry/profiling-node from 10.36.0 to 10.39.0.
Release notes
Sourced from
@sentry/profiling-node's releases.... (truncated)
Changelog
Sourced from
@sentry/profiling-node's changelog.... (truncated)
Commits
ab54c5cMake@sentry/opentelemetrynot a peer dep in node-coref822e69chore: Lint lerna.jsonc4708d2release: 10.39.0b5e3094chore: Revert to lerna v8 (#19294)9dea581Merge pull request #19281 from getsentry/prepare-release/10.39.012e467fmeta(changelog): Update changelog for 10.39.0d7df7d4ref(sveltekit): Useuntrackto read route id without invalidation (#19272)24b2ef2fix(sveltekit): Detect used adapter viasvelte.config.js(#19270)e051be4feat(node-core): Add outgoing fetch trace propagation to light mode (#19262)eaf297fref(core): Move shouldPropagateTraceForUrl from opentelemetry to core (#19258)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)