Skip to content

[CI] slow down fast-duration converge #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lihao-figma merged 1 commit into from
Dec 2, 2025
Merged

[CI] slow down fast-duration converge #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ruby/lib/ci/queue/redis/update_test_duration_moving_average.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ module CI
module Queue
module Redis
class UpdateTestDurationMovingAverage
def initialize(redis, key: "test_duration_moving_averages", smoothing_factor: 0.2)
def initialize(redis, key: 'test_duration_moving_averages', smoothing_factor: 0.2, slow_smoothing_factor: 0.01)
@redis = redis
@key = key
@smoothing_factor = smoothing_factor
@slow_smoothing_factor = slow_smoothing_factor
end

def update_batch(pairs)
Expand All @@ -20,10 +21,13 @@ def update_batch(pairs)
pairs.each_with_index do |(test_id, duration), idx|
current = current_values[idx]
new_avg = if current
@smoothing_factor * duration + (1 - @smoothing_factor) * current.to_f
else
duration
end
current_avg = current.to_f
# Use slow smoothing if new duration is faster (shorter), fast smoothing if slower (longer)
factor = duration < current_avg ? @slow_smoothing_factor : @smoothing_factor
factor * duration + (1 - factor) * current_avg
else
duration
end
writes << [test_id, new_avg]
end

Expand Down