use filbeam contract in terminator n correct env names#604
Open
DarkLord017 wants to merge 2 commits intofilbeam:mainfrom
Open
use filbeam contract in terminator n correct env names#604DarkLord017 wants to merge 2 commits intofilbeam:mainfrom
DarkLord017 wants to merge 2 commits intofilbeam:mainfrom
Conversation
DarkLord017
requested review from
bajtos,
juliangruber and
pyropy
as code owners
pyropy
requested changes
Feb 10, 2026
Contributor
pyropy
left a comment
pyropy
left a comment
There was a problem hiding this comment.
Great work! Let's just rename the FILBEAM_CONTROLLER_PRIVATE_KEY to FILBEAM_OPERATOR_CONTROLLER_PRIVATE_KEY since the contract name is FilBeamOperator.
| @@ -1,4 +1,4 @@ | |||
| /** @import {WorkflowStep} from 'cloudflare:workers' */ | |||
| /** @import {WorkflowStep} from "cloudflare:workers" */ | |||
Contributor
There was a problem hiding this comment.
Are you using npm run lint:fix to format the code or you're using your editor?
Contributor
There was a problem hiding this comment.
This issue has not been resolved
pyropy
requested changes
Feb 18, 2026
Contributor
pyropy
left a comment
pyropy
left a comment
There was a problem hiding this comment.
Please run npm run lint:fix as formatting is not consistent with the rest of the codebase.
| // Support both payment-settler, terminator and usage-reporter private keys | ||
| const privateKey = /** @type {`0x${string}`} */ ( | ||
| env.FILBEAM_CONTROLLER_PRIVATE_KEY || | ||
| env.FILBEAM_OPERATOR_CONTROLLER_PRIVATE_KEY || |
Contributor
There was a problem hiding this comment.
We need to regenerate workflows/worker-configuration.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #362
i just found contract calls in terminate directory are subgraphs and events also supposed to be proxied ?
Also i did not push worker configuration , was that supposed to be pushed ?
pls review @pyropy