Improve Recycle Bin item existence check performance#18424
Open
muko wants to merge 1 commit intofiles-community:mainfrom
Open
Improve Recycle Bin item existence check performance#18424muko wants to merge 1 commit intofiles-community:mainfrom
muko wants to merge 1 commit intofiles-community:mainfrom
Conversation
yair100
reviewed
Apr 26, 2026
| /// <inheritdoc/> | ||
| public bool HasItems() | ||
| { | ||
| return QueryRecycleBin().NumItems > 0; |
Member
There was a problem hiding this comment.
The QueryRecycleBin method is used in other places as well. IF there is an alternative, we should update the method directly so these improvements apply across the board.
Contributor
Author
There was a problem hiding this comment.
QueryRecycleBin() returns whether the Recycle Bin exists, along with the total item count and total size.
Since HasItems() only needs to check whether any items exist, calling QueryRecycleBin() is unnecessary here.
0x5bfa
reviewed
May 1, 2026
Member
0x5bfa
left a comment
0x5bfa
left a comment
There was a problem hiding this comment.
I'm very against using the C# APIs over the Shell APIs but if this does improve the performance, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Bug: Slow file selection when Recycle Bin has many files #18420
Steps used to test these changes