Code Quality: Implement AOT-safe json settings class#18454
Draft
0x5bfa wants to merge 3 commits intofiles-community:mainfrom
Draft
Code Quality: Implement AOT-safe json settings class#184540x5bfa wants to merge 3 commits intofiles-community:mainfrom
0x5bfa wants to merge 3 commits intofiles-community:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
The current settings system is not AOT-safe since it relies on reflection when deserializing. The new one is strongly typed and AOT-safe.
The new class has built-in support for defaulting a setting's value, customizing when getting a setting, migrating a setting.
DefaultValue = OpenInIDEOption.GitReposDefaultValueCallback = nameof(GetDefaultIDEName)GetValueCallback = nameof(GetInfoPaneSize)MigrateValueCallback = nameof(MigrateLegacySingleClickSettings)Steps used to test these changes
Not yet