Create CardsCollectionViewVerticalLayout.swift#3
Open
Viscmad wants to merge 6 commits intofilletofish:masterfrom
Open
Create CardsCollectionViewVerticalLayout.swift#3Viscmad wants to merge 6 commits intofilletofish:masterfrom
Viscmad wants to merge 6 commits intofilletofish:masterfrom
Conversation
*Renamed to VerticalCollectionViewLayout *Fixed issue with scrolling to 1st index (line 58 changed)
Owner
|
@Viscmad thank you for the PR! I will take a look asap. |
Owner
|
@Viscmad Hi, Feel free to look at it and review. |
filletofish
reviewed
Jan 3, 2018
| import UIKit | ||
|
|
||
|
|
||
| protocol CardsCollectionViewLayout { |
Owner
There was a problem hiding this comment.
Use the protocol to constraint different layouts for common interface.
filletofish
reviewed
Jan 3, 2018
|
|
||
| protocol CardsCollectionViewLayout { | ||
| var itemSize: CGSize { get set } | ||
| var spacing: CGPoint { get set } |
Owner
There was a problem hiding this comment.
Use CGPoint instead CGFloat to add different spacing for different axis.
|
@filletofish @Viscmad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of Vertical Collection View Layout as separate file.