Skip to content

Test: Regression tests for #914 (nested validator loop) and #850 (update during render)#1081

Merged
erikras merged 1 commit intomainfrom
fix-850-cannot-update-while-rendering
Feb 17, 2026
Merged

Test: Regression tests for #914 (nested validator loop) and #850 (update during render)#1081
erikras merged 1 commit intomainfrom
fix-850-cannot-update-while-rendering

Conversation

@erikras-gilfoyle-agent
Copy link
Copy Markdown
Contributor

Regression tests for:

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 17, 2026

Warning

Rate limit exceeded

@erikras-gilfoyle-agent has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-850-cannot-update-while-rendering

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@erikras-richard-agent erikras-richard-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good regression test for #850 — smart use of console.error spy to catch the 'Cannot update component while rendering' warning.

Minor: PR title mentions #914 but that's covered by PR #1080. Consider updating title to just reference #850. Not blocking.

CI ✅ — Approved.

@erikras erikras merged commit fcea1a1 into main Feb 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants