Skip to content

refactor(cli): split remote install helpers#75

Merged
peters merged 1 commit intomainfrom
refactor/cli-install-remote-phase-2
Apr 10, 2026
Merged

refactor(cli): split remote install helpers#75
peters merged 1 commit intomainfrom
refactor/cli-install-remote-phase-2

Conversation

@peters
Copy link
Copy Markdown
Contributor

@peters peters commented Apr 10, 2026

Summary

  • split crates/surge-cli/src/commands/install/remote.rs into focused leaf modules for execution, published installer planning, activation, staging, state, and shared types
  • keep the runtime install::remote surface stable while moving test-only helpers behind #[cfg(test)] reexports
  • remove the stale remote baseline entry and update the cleanup rollout tracker for the active phase

Validation

  • ./scripts/sync-surge-core-vendor.sh --check
  • ./scripts/check-version-sync.sh
  • cargo fmt --all -- --check
  • RUSTFLAGS="-D warnings" cargo test --workspace
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_used
  • cargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedantic
  • dotnet format dotnet/Surge.slnx --verify-no-changes
  • dotnet test dotnet/Surge.slnx --configuration Release
  • cargo test -p surge-cli commands::install::
  • cargo clippy -p surge-cli --all-targets --all-features -- -D warnings -W clippy::pedantic
  • ./scripts/check-maintainability.sh

Impact

  • no intended user-facing behavior changes
  • the remaining maintainability backlog is reduced to crates/surge-cli/src/commands/install/mod.rs
  • the active cleanup phase now matches the codebase and baseline docs

@peters peters marked this pull request as ready for review April 10, 2026 12:54
@peters peters merged commit 6c511c9 into main Apr 10, 2026
12 checks passed
@peters peters deleted the refactor/cli-install-remote-phase-2 branch April 10, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant