harden(core): validate release index app_id and require app-scoped prefix#79
Merged
harden(core): validate release index app_id and require app-scoped prefix#79
Conversation
…orage prefix - Pack builder rejects release index whose app_id does not match the current pack target, preventing silent cross-app contamination. - Pack builder populates empty app_id on legacy indexes. - Update manager requires the app-scoped storage prefix when derivable instead of probing root first and falling back. Eliminates an unnecessary storage request and ensures the client always reads from the same path the pack builder writes to. - Tests updated to use app-scoped storage layout matching production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_iddoes not match the current pack target, preventing silent cross-app index contamination.app_idon legacy indexes duringupdate_release_index.NotFound. Eliminates an unnecessary storage request and ensures the client reads from the same path the pack builder writes to.Test plan
test_update_release_index_rejects_existing_index_for_other_apptest_check_for_updates_prefers_app_scoped_prefix_when_root_index_is_mismatchedtest_check_for_updates_requires_app_scoped_prefix_when_it_is_derivable