Release v1.19.0#93
Closed
oerlandsen wants to merge 3 commits intostablefrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release v1.19.0 — cherry-picks the post-1.18.0 commits onto
stable.Includes:
userAgentoption inFintocconstructorisISODateto prevent plain strings being parsed as datesWhy cherry-pick instead of merging master directly
The previous release PR (#88) was squash-merged, which collapsed the v1.18.0 commits into a single new commit on
stable(737b163) with no graph link to master's13e9945. Merging master → stable now would replay every commit since352f867and conflict against the squashed copy of those same changes.This PR applies only the genuinely new commits (#89/#90/#91) on top of stable.
Important — merge with a merge commit, NOT squash
Use Create a merge commit when merging this PR. That records master's tip as a parent of stable, restoring the graph link so the next release PR has a clean merge base. Squashing again will reintroduce the drift.
Test plan
stableshows only the three expected commits