Skip to content

Conversation

@firstof9
Copy link
Owner

@firstof9 firstof9 commented Dec 30, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Firmware check now displays the complete release notes from GitHub instead of truncated summaries.
  • Chores

    • Version bumped to 0.1.91.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

Version is bumped from 0.1.90 to 0.1.91. In the firmware check logic, the GitHub release body is now stored directly under "release_notes" instead of being truncated to create a "release_summary", simplifying the data handling.

Changes

Cohort / File(s) Summary
Version Bump
setup.py
Version updated from 0.1.90 to 0.1.91
Release Notes Handling
openevsehttp/__main__.py
firmware_check() now stores release body directly as "release_notes" instead of computing a truncated "release_summary"; removed 255-character truncation logic

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A version hops up, oh what cheer,
Release notes flow without a shear,
No truncation needed here,
Full details shining crystal clear! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing release summary computation with direct release notes storage.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 605b93e and d77c2b4.

📒 Files selected for processing (2)
  • openevsehttp/__main__.py
  • setup.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: coverage
🔇 Additional comments (2)
setup.py (1)

9-9: LGTM! Version bump aligns with the API change.

The version increment from 0.1.90 to 0.1.91 appropriately reflects the changes made to the firmware_check method's return structure.

openevsehttp/__main__.py (1)

590-590: No action required; the breaking change has been properly implemented.

The search found no remaining references to "release_summary" in the codebase. The dictionary key has been fully migrated to "release_notes", and the 255-character truncation has been removed. Within this repository, no internal code consumes these dictionary keys except the return statement in firmware_check(), and the test suite only validates the "latest_version" key, so the change does not introduce any breakage within the codebase.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Pylint (4.0.4)
openevsehttp/__main__.py
setup.py

Comment @coderabbitai help to get the list of available commands and usage tips.

@firstof9 firstof9 added the enhancement New feature or request label Dec 30, 2025
@firstof9 firstof9 merged commit c334d26 into main Dec 30, 2025
5 checks passed
@firstof9 firstof9 deleted the release-notes branch December 30, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants