Input refactor new #516
Merged
Input refactor new #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicklag
force-pushed
the
input-refactor-new
branch
3 times, most recently
from
6041cc7 to
6f73d49
Compare
The InputCollector's job is entirely local. It does not need to access any network updated resources. It's job is to get the local player's current inputs however neccessary. This means both the ControlMapping and the ControlSource can be handled with local resources or Self stored fields/values if neccessary.
This is implemented in jumpy but unused and unneccessary. If anything like this is implemented it should probably be done through a blanket implementation.
This moves several traits out of networking::input to be used for offline or wasm32 if needed.
These traits are no longer network specific so the new names are more appropriate.
zicklag
force-pushed
the
input-refactor-new
branch
from
6f73d49 to
d1efaa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.